[m-rev.] for review: Fixing samples/rot13_concise + libxml compile error

Julien Fischer jfischer at opturion.com
Mon Mar 3 00:04:28 AEDT 2014


Hi Sebastian,

On Fri, 28 Feb 2014, Sebastian Godelet wrote:

> for a quick review, my last problems I had with going through all the
> samples and extras, except the wix compiler, that one I didn't figure out yet.
> 
> branch: master
> boehm_gc/.gitignore b/boehm_gc/.gitignore:
>     ignoring Windows 'cl' .obj files

Change that to:

       Ignore .obj files.

> extras/xml/xml.dtd.m b/extras/xml/xml.dtd.m:
> extras/xml/xml.parse.m b/extras/xml/xml.parse.m:
>     Changing multiplicity ('1') -> one, such that it compiles (and works)
>     in the C# grade.

Change to:

       Change the name of the functor ('1') in the multiplicity/0 type
       to one.  The former name does not (yet) work with the C# grade.

> samples/rot13/rot13_concise.m:
>     added missing func and pred declarations

Change to:

      Add missing func and pred declarations.

(I suspect, however, that their omission was deliberate; the authors
presumably thought it more concise to infer the predmodes of local
procedures rather than explicitly declare them.)

>     changed string index_det -> string.det_index.

Change to:

       Update calls to string.index_det to use string.det_index.

> samples/solver_types/sudoku.m:
>     The solution grid is now in a 3x3 block format,
>     for that the row number is accumulated in write_solution predicate.

Change to:

       Output the solution in a 3x3 grid.

The rest of the change looks fine.

Cheers,
Julien.


More information about the reviews mailing list