[m-rev.] for review: [PATCH 1/4] Add thread_safe attribute to store procedures.

Julien Fischer jfischer at opturion.com
Fri Jul 25 16:02:38 AEST 2014

On Fri, 25 Jul 2014, Peter Wang wrote:

> On Wed, 23 Jul 2014 16:48:00 +1000, Julien Fischer <jfischer at opturion.com> wrote:
>> It simple enough:
>> - thread safety is an issue for mutvars attached to the I/O state because
>>   the I/O state can be split by a call to spawn and in principle both
>> threads
>>   can access the mutavar.
>> - thread safety is not an issue for mutvars attached to other states since
>>   the states must be unique and cannot be split by a call to spawn.
>>   (The inst of the closure passed to spawn prevents this.)
> I will add these comments.  Let me know if you do or don't want
> the four patches on the 14.01 branch.

I don't think they should be added to the branch.  The change to the
store module should be mentioned in the NEWS file, there may be existing
programs that rely on the mutvar access operations using the global


More information about the reviews mailing list