[m-rev.] for post-commit review: fix string.from_char_list in C# and Java grades
novalazy at gmail.com
Fri Jul 4 10:02:50 AEST 2014
On Thu, 3 Jul 2014 17:47:21 +1000 (EST), Julien Fischer <jfischer at opturion.com> wrote:
> For post-commit review by anyone.
> Branches: 14.01, master
> Fix the behaviour of string.from_char_list in C# and Java grades.
> The predicate string.from_char_list and string.from_reverse_char_list should
> throw an exception if their input lists contain the null character. This
> was not done for the C# and Java grades for the former, and the C# grade for
> the latter.
> (This fixes the failure of tests/hard_coded/null_char in the C# grade and
> almost fixes it for the Java grade.)
> Make the above predicates throw an exception if their input lists
> contain the null character.
> Announce the above fix.
I think embedded null characters should be allowed when the underlying
string representation allows it, so this was more a bug in the
documentation. Obviously, from_char_list and from_reverse_char_list
should have consistent behaviour within the same grade.
More information about the reviews