[m-rev.] add character ranges to extras/lex

Paul Bone paul at bone.id.au
Mon Feb 24 11:33:04 AEDT 2014


On Sun, Feb 23, 2014 at 09:03:13PM +0100, Sebastian Godelet wrote:
> Greetings,
> 
> I had some more time to do more substantial improvements (that I think) to
> the extra/lex library.
> 
> It was easier to include all previous patches and the new code into a pull
> request (based on master, but actually any recent branch should be fine)
> I'm sorry that I didn't write the patch in one chunk, I'm still learning
> how to program in Mercury, I guess I caused to much traffic in the mailing
> list :(

It's okay, I think I've figured it out.

I find many small changes (eg, in a pull request) easier to review, provided
that each change makes sense separately.  But other developers disagree, it's
hard to please everyone.  That said, sometimes it's difficult to separate
some changes as they depend on one-another.


-- 
Paul Bone



More information about the reviews mailing list