[m-rev.] for review: add is_(leading|trailing)_surrogate/1 to char module

Sebastian Godelet sebastian.godelet+github at gmail.com
Mon Dec 22 17:39:20 AEDT 2014


On Mon, 22 Dec 2014 16:18:07 +1100
Paul Bone <paul at bone.id.au> wrote:

> On Sun, Dec 21, 2014 at 10:24:37AM +0800, Sebastian Godelet wrote:
> > For review by anyone.
> > 
> > For input validation and character encoding transformations
> > it is essential to check for surrogate characters and their correct
> > sequence.
> > 
> > NEWS:
> >     Announce the addition of is_(leading|trailing)_surrogate/1.
> > 
> > library/char.m:
> >     Add is_leading_surrogate/1 which succeeds if a character is a
> >     leading surrogate character.
> >     is_trailing_surrogate/1 succeeds if the character is a trailing
> >     surrogate character.
> > 
> > Sebastian.
> 
> Thanks Sebastian,
> 
> This looks good to me.  If you open a pull request I'll merge the
> changes.

Opened a pull request:
https://github.com/Mercury-Language/mercury/pull/17

> 
> Cheers.
> 
> 




More information about the reviews mailing list