[m-rev.] for review: additions for the calendar module

Ian MacLarty imaclarty at opturion.com
Thu Dec 4 13:13:35 AEDT 2014


On Thu, Dec 4, 2014 at 1:04 PM, Julien Fischer <jfischer at opturion.com>
wrote:

>
> For review by anyone.
>
> -----------------------
>
> Additions for the calendar module.
>
> library/calendar.m:
>     Add predicates and functions for converting between 1-based
>     and 0-based month numbers and values of the month/0 type.
>     The former are useful when dealing with human-provided dates
>     whereas the latter are useful when interacting with dates
>     provided from some foreign language (C and Java for example).
>
>     Add a predicate for testing for equality of dates ignoring
>     their time component.
>
>     Replace the locally defined predicate char_to_digit/2 with
>     calls to char.decimal_digit_to_int/2
>
>     Fix some formatting issues.
>
> tests/hard_coded/calendar_test.{m,exp}:
>     Extend this test case to cover the functionality added
>     above.
>
> NEWS:
>         Announce the additions.
>
>
Looks fine.

Ian.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.mercurylang.org/archives/reviews/attachments/20141204/80feb056/attachment.html>


More information about the reviews mailing list