[m-rev.] write_float_special.exp4

Julien Fischer jfischer at opturion.com
Thu Aug 21 00:53:56 AEST 2014


Hi Zoltan,

On Wed, 20 Aug 2014, Zoltan Somogyi wrote:

> On my laptop, the output of the hardcoded/write_float_special test has long been:
>
> Inf: inf
> -Inf: -inf
> NaN: -nan
>
> The expected output does not have the - sign in front of the nan.
>
> I don't particularly care about the exact details of how we format non-number
> numbers, but having a test case always failing is annoying.
>
> I think either the MR_is_nan test should be moved earlier in MR_sprintf_float,
> to before the - is printed, or the output above should be added as tests/
> hardcoded/write_float_special.exp4, with corresponding .exp[56] for infinity/
> Infinity. What do others think?

The former: the profileration of expected outputs for the above (and
related) test case(s) is already annoying.

I am already working on a change to standardise the format of special
float values (see for example bug #348) in Mercury across all target
languages / platforms.  I'll fix the above as part of that too.

Cheers,
Julien.



More information about the reviews mailing list