[m-rev.] for review: Enable thread-local allocation and parallel marking on more platforms.

Julien Fischer jfischer at opturion.com
Tue Aug 12 14:25:33 AEST 2014


On Tue, 12 Aug 2014, Peter Wang wrote:

> On Tue, 12 Aug 2014 11:19:25 +1000 (EST), Julien Fischer <jfischer at opturion.com> wrote:
>>
>> On Tue, 12 Aug 2014, Peter Wang wrote:
>>
>>> I intend to apply this on the 14.01 branch.  I think it should be fine,
>>> but if someone could test it on an SMP OS X machine (e.g. bootcheck in
>>> hlc.par.gc) then that would be better.
>>
>> By "someone", do you mean me?
>
> Yes :)

On OS X, I get the following failures when bootchecking in hlc.par.gc

     hard_coded/spawn_native
     hard_coded/thread_barrier_test
     hard_coded/tl_backjump_test
     par_conj/spawn_many
     par_conj/thread_barrier

All are aborting due to segmentation faults.  I'm not sure if this is
a result of your patch or if it's happening anyway.   (I'll try again
without your patch.)

Also, the following patch needs to be applied to the Boehm GC in order
to avoid compilation warnings with clang when parallel marking is
enabled (and probably any other C compiler that is in C99 mode).

Cheers,
Julien.

--------------------------------------------------

diff --git a/boehm_gc/misc.c b/boehm_gc/misc.c
index ae34a9a..14c7be2 100644
--- a/boehm_gc/misc.c
+++ b/boehm_gc/misc.c
@@ -25,6 +25,7 @@
   */

  #include "private/gc_pmark.h"
+#include "private/pthread_support.h"

  #include <stdio.h>
  #include <limits.h>



More information about the reviews mailing list