[m-rev.] for review: fix mantis bug 351

Zoltan Somogyi zoltan.somogyi at runbox.com
Mon Aug 11 10:48:39 AEST 2014



On Mon, 11 Aug 2014 10:40:48 +1000, Peter Wang <novalazy at gmail.com> wrote:
> I suggest a descriptive title, e.g.
> 
> Fix has_parallel_conj field on generated procedures (Mantis bug #351).

Done.

> >      % argument MaybeDeclaredDetism
> > +        % Inferred determinism gets initialized to `erroneous'.
> > +        % This is what `det_analysis.m' wants. det_analysis.m
> > +        % will later provide the correct inferred determinism for it.
> >      InferredDetism = detism_erroneous,
> >      goal_info_init(GoalInfo),
> >      ClauseBody = hlds_goal(conj(plain_conj, []), GoalInfo),
> 
> Indentation?

I wanted it to look different from the previous comments, which list arguments
of proc_info that are not computed there.

That comment is not new; I just moved it. It is one of the field initializations
that I think should be reviewed, because while it is appropriate for procedures
created before determinism analysis, it is NOT appropriate for procedures
created after it.

> It looks good otherwise.  Thanks for fixing it so quickly.

You are welcome.

Zoltan.




More information about the reviews mailing list