[m-rev.] for reviews: add --system-env-type

Julien Fischer jfischer at opturion.com
Fri Sep 27 12:35:42 AEST 2013



On Fri, 27 Sep 2013, Paul Bone wrote:

> On Thu, Sep 26, 2013 at 11:05:51AM +1000, Julien Fischer wrote:
>>
>> For review by anyone.
>>
>> ---------------------
>>
>> compiler/options.m:
>> 	Add a new option, --system-env-type, which allows the "system"
>> 	environment to be specified.
>>
>> 	Make the --env-type option also set the system environment.
>
> I interpreted this sentance incorreclty, I added "instead of the host env
> type" rather than "as well as the host and target env types".  I interpreted
> it this way because in the text above you're comparing the system and host
> environment types.  I suggest adding clarification.

Done.

>> diff --git a/compiler/options.m b/compiler/options.m
>> index 4a07250..20acd83 100644
>> --- a/compiler/options.m
>> +++ b/compiler/options.m
>> @@ -5876,11 +5880,15 @@ options_help_build_system -->
>>          "\tprograms will be invoked.",
>>          "\tThe <type> should be one of `posix', `cygwin', `msys', or",
>>          "\t`windows'.",
>> -        "\tThis option is equivalent to setting both --host-env-type and",
>> -        "\t--target-env-type to <type>.",
>> +        "\tThis option is equivalent to setting all of --host-env-type,",
>> +        "\t--system-env-type and --target-env-type to <type>.",
>>          "--host-env-type <type>",
>>          "\tSpecify the environment type in which the compiler will be",
>>          "\tinvoked.",
>> +        "--system-env-type <type>",
>> +        "\tSpecify the environment type in which external programs invoked by the",
>> +        "\tcompiler will run.",
>> +        "\tIf not specified, this defaults to the value given by --host-env-type.",
>>          "--target-env-type <type>",
>>          "\tSpecify the environment type in which generated programs will be",
>>          "\tinvoked."
>
> Overlong lines.

Fixed.

>> diff --git a/doc/user_guide.texi b/doc/user_guide.texi
>> index 29992bd..39debd2 100644
>> --- a/doc/user_guide.texi
>> +++ b/doc/user_guide.texi
>> @@ -9559,6 +9559,13 @@ Specify the environment type in which the compiler will be invoked.
>>  (See above for a list of supported environment types.)
>>
>>  @sp 1
>> + at item --system-env-type @var{type}
>> + at findex --system-env-type
>> +Sspecify the environment type in which external programs invoked by the compiler
>> +will run.
>> +If not specified, this defaults to the value given by @samp{--host-envy-type}.
>> +
>> + at sp 1
>
> More overlong lines
>
> --host-envy-type?  s/envy/env/

Fixed.  (Also fixed the misspelling of Specify above.)

Cheers,
Julien.



More information about the reviews mailing list