[m-rev.] For review: Fix crashes in parallel grades with gcc 4.6+ (bug #294)

[Paul Bone]

On Thu, Sep 05, 2013 at 03:56:38PM +1000, Julien Fischer wrote:
>
> Hi Paul,
>
> On Thu, 5 Sep 2013, Paul Bone wrote:
>
>> For review by Julien (I've been discussing the bug with him already).  I
>> propose to commit this to the release branch.
>
> The only reason 13.05.2 hasn't been released is you told me to wait for
> this.

Yep.  Just making it clear, especially to others who may be reading the
mailing list more casually.

>> +# which grades are affected.
>> +#
>> # For alpha, mips, and ARM, and probably on other architectures, when using
>> # non-local gotos we need -fomit-frame-pointer, otherwise when compiling
>> # with --no-c-optimize we run into a problem similar to the one above:
>> @@ -2541,6 +2557,23 @@ case "$ac_cv_prog_gcc" in yes)
>>     esac
>>     ;;
>> esac
>> +
>> +# Determine if $CFLAGS_FOR_NO_REORDER_FUNCTIONS is needed.
>> +case "$C_COMPILER_TYPE" in
>> +    # Check if the option is not required, and otherwise include the option.
>> +    # No need to check gcc < 3.3 as the option didn't exist.
>> +    gcc_3 | gcc_4_1* | gcc_4_2* | gcc_4_3* | gcc_4_4* | gcc_4_5*)
>
> I think the first alternative there should be "gcc_3*".
> C_COMPILER_TYPE will never match against "gcc_3".
>

Yes, thanks.

I've made the other corrections.

Thanks.


-- 
Paul Bone
http://www.bone.id.au