[m-rev.] diff: disable mfilterjavac by default

Paul Bone paul at bone.id.au
Tue Oct 15 16:39:37 AEDT 2013


On Tue, Apr 23, 2013 at 05:41:43PM +1000, Julien Fischer wrote:
> Disable mfilterjavac for now.
> 
> mfilterjavac is currently causing problems when installing the java grade
> from
> the stage 2 dir.  It can be re-enabled when the following sequence of
> actions
> works correctly:
> 
> (1) Build stage 1 using rotd-2013-04-18
> (2) Bootcheck (or otherwise build the stage 2 compiler).
> (3) cd stage2 && mmake install (with the java grade as one of the grades
>     to install).

Hi Julien.

I just tried these steps, except with ROTD 2013-10-01 and it works for me.
Perhaps because the ROTD understands the --mfilterjavac option.  Is there
something that I'm missing? 

I'm using a workspace based on the current master with mfilterjavac
re-enabled.

> diff --git a/compiler/options.m b/compiler/options.m
> index 1cc2553..234c112 100644
> --- a/compiler/options.m
> +++ b/compiler/options.m
> @@ -1838,7 +1838,9 @@ option_defaults_2(link_option, [
>      mkinit_erl_command                  -   string("mkinit_erl"),
>      demangle_command                    -   string("mdemangle"),
>      filtercc_command                    -   string("mfiltercc"),
> -    filterjavac_command                 -   string("mfilterjavac"),
> +    % XXX filterjavac_command is disabled until the addition of
> +    % mfilterjavac has bootstrapped.
> +    filterjavac_command                 -   string(""),
>      trace_libs                          -   string(""),
>      thread_libs                         -   string(""),
>      hwloc_libs                          -   string(""),

According to your patch all I had to do was wait.

Thanks.


-- 
Paul Bone
http://www.bone.id.au



More information about the reviews mailing list