[m-rev.] for review 1/2: Add test cases for bug300

Julien Fischer jfischer at opturion.com
Mon Oct 7 11:53:39 AEDT 2013


On Wed, 2 Oct 2013, Paul Bone wrote:

> Add test cases for bug300

I find it inconvenient that this diff is separate from the one that
actually fixes the bug.

> tests/valid/bug300.m:
> tests/valid/Mmakefile:
>    Add simple test case
> tests/valid/Mercury.options:
>    Run the new test case with --optimize-constructor-last-call
> tests/hard_coded/bug300.m:
> tests/hard_coded/bug300.exp:
> tests/hard_coded/Mmakefile:
>    This test case can detect the bug in C grades, where as the test case in
>    tests/valid/bug300.m only works in Java grades.

Presumably, this one also triggers the bug in Java grades?  If so, why
do we need two test cases?
> tests/hard_coded/Mercury.options:
>    Setup MCFLAGS so that the test case can detect the bug.

You should also mention that the bug has been fixed in the NEWS file for


More information about the reviews mailing list