[m-rev.] for review 2/2: Refine Micheal's pqueue changes

Julien Fischer jfischer at opturion.com
Tue Nov 26 15:48:54 AEDT 2013


Hi,

Splitting this change into two mails makes it harder to review,
(Particularly, as the second fixes issues with the first).   Could
you please not do this.


On Sun, 24 Nov 2013, Paul Bone wrote:

> For review by anyone.
>
> Branches: master
>
> ---
>
> Refine Micheal's pqueue changes
>
> library/pqueue.m:
>    Refine Micheal's changes where necessary to conform to our style.
>
> NEWS:
>    Updated news file.
> ---
> NEWS             |  6 ++++++
> library/pqueue.m | 23 ++++++++++++++---------
> 2 files changed, 20 insertions(+), 9 deletions(-)
>
> diff --git a/NEWS b/NEWS
> index 4abef36..ef60322 100644
> --- a/NEWS
> +++ b/NEWS
> @@ -21,6 +21,12 @@ Changes to the Mercury standard library:
> * We have added the following predicates to the list module: foldr2/6 and
>   foldr3/8.
>
> +* We have added the following predicates to the pqueue module:
> +  is_empty/1, peek/3, peek_key/2, peek_value/2, det_peek/3 and merge/3.
> +  We have also added the following fuctions to the pqueue module:
> +  det_peek_key/1 and det_peek_value/1.


I suggest:

    * We have add the following predicate and functions to the pqueue
      module: etc etc ...


Cheers,
Julien.



More information about the reviews mailing list