[m-rev.] for review: Provide a helpful error if no C sharp compiler could be found
Julien Fischer
jfischer at opturion.com
Thu May 23 22:57:14 AEST 2013
On Thu, May 23, 2013 at 10:39 PM, Paul Bone <paul at bone.id.au> wrote:
> On Thu, May 23, 2013 at 10:12:19PM +1000, Julien Fischer wrote:
> > On Thu, May 23, 2013 at 8:48 PM, Paul Bone <paul at bone.id.au> wrote:
>
> > > --- a/m4/mercury.m4
> > > +++ b/m4/mercury.m4
> > > @@ -369,6 +369,13 @@ EOF
> > > esac
> > > done
> > >
> > > +# If the user specified one or more compilers and we couldn't find any
> > > +# then abort configuration.
> > > +if test "$mercury_cv_with_csharp_compiler" != "" -a "$CSC" = ""; then
> > > + AC_MSG_ERROR([No C sharp compilers could be found.]
> >
> >
> > How about:
> >
> > No working C# compiler could be found.
>
> s/working/suitable/ Since a C# compiler might work but not support
> generics.
Fine, although didn't your change add a separate test for whether generics
are supported?
Cheers,
Julien.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.mercurylang.org/archives/reviews/attachments/20130523/a1fb4f98/attachment.html>
More information about the reviews
mailing list