[m-rev.] for review 1/3: Move pointer/equals to new private shared library module.
Julien Fischer
jfischer at opturion.com
Fri Jun 28 16:50:04 AEST 2013
On Fri, 28 Jun 2013, Paul Bone wrote:
> On Fri, Jun 28, 2013 at 04:32:12PM +1000, Julien Fischer wrote:
>>
>> On Fri, 28 Jun 2013, Paul Bone wrote:
>>
>>> For review by Julien.
>>>
>>> Move pointer/equals to new private shared library module.
>>>
>>> This will allow other library code to use this predicate.
>>>
>>> library/private.m:
>>> library/version_hash_table.m:
>>> As above.
>>>
>>> I've created the new module private.m for any code that is shared amoung
>>> library modules but is intended for Mercury implementors. Unlike
>>> private_builtin.m the predicates in private.m are not builtin.
>>
>> Why add a new module? This should just go in private_builtin.
>
> Because, like the message says, it's not builtin.
The contents of private_builtin are not quite as restricted as the
meaning you are giving to the word "builtin". We are quite happy
to have things like typed_unify defined in private_builtin and
called from various library modules (e.g. univ), so I see no
reason not to do this for pointer_equals as well. Especially,
since it avoids having to add a new module for one single
implmentor-only predicate.
Cheers,
Julien.
More information about the reviews
mailing list