[m-rev.] for review: Make some cord functions tail recursive.

Peter Wang novalazy at gmail.com
Thu Jun 13 14:32:04 AEST 2013


On Thu, 13 Jun 2013 14:23:05 +1000 (EST), Julien Fischer <jfischer at opturion.com> wrote:
> 
> On Thu, 13 Jun 2013, Peter Wang wrote:
> 
> > For review.
> > ---
> >
> > Add test case for cords.
> >
> > Test the recently changed functions more comprehensively:
> > cord.list, cord.rev_list, cord.cord_list_to_cord, cord.cord_list_to_list.
> >
> > The existing test_cord.m is deficient, and did not reveal a bug in the
> > previous implementation of cord.rev_list (the non-tail-recursive one).
> >
> > tests/hard_coded/Mmakefile:
> > tests/hard_coded/test_cord2.exp:
> > tests/hard_coded/test_cord2.m:
> >        Add test case.
> 
> That's fine.

Thanks. Committed.

Peter



More information about the reviews mailing list