[m-rev.] for review: Make some cord functions tail recursive.

Peter Wang novalazy at gmail.com
Thu Jun 13 12:43:08 AEST 2013


On Thu, 13 Jun 2013 12:30:14 +1000 (EST), Julien Fischer <jfischer at opturion.com> wrote:
> 
> On Thu, 13 Jun 2013, Peter Wang wrote:
> 
> > Branches: 13.05, master
> > ---
> >
> > Make these functions tail recursive:
> >
> > 	cord.list
> > 	cord.rev_list
> > 	cord.cord_list_to_cord
> > 	cord.cord_list_to_list
> >
> > library/cord.m:
> > 	As above.
> 
> I assume we have tests in the test suite that test the functionality of
> the above?

There is only one test case and it is severely deficient.  I'm trying to
write another one now.

> 
> Looks fine otherwise -- I'd like to build the 13.05.1 release sometime
> today; do you have any other outstanding changes.

No.

Peter



More information about the reviews mailing list