[m-rev.] for review: Added cord.condense/2

Zoltan Somogyi zs at unimelb.edu.au
Tue Jul 2 06:57:57 AEST 2013

On 01-Jul-2013, Julien Fischer <jfischer at opturion.com> wrote:
> Having the state variable transformation also depend upon argument types
> would be ugly.  (And probably fairly difficult to implement.)

Yes, it would, mainly because state variable expansion now happens during the
creation of the HLDS from the parse tree, way before the type checking phase.

Paul's idea requires knowing the type of the state variable, which (if it
is a local variable) is known only during type checking. Delaying state
variable expansion until that time would require expanding the HLDS to allow
it to represent unexpanded state variables, and teaching all compiler phases
until and including type checking to handle the new parts of the HLDS.
This would be a HUGE amount of work, and I don't think the result would be
worth that much even for people who like the idea of type-dependent expansions.


More information about the reviews mailing list