[m-rev.] for review: Added cord.condense/2

Julien Fischer jfischer at opturion.com
Mon Jul 1 16:57:58 AEST 2013


On Mon, 1 Jul 2013, Paul Bone wrote:

> For review by anyuone.
>
> Added cord.condense/2
>
> library/cord.m:
>    Added new predicate and function

Full stop after that.


I don't think there should be a predicate version.
(I know the list module often defines both predicate and function
versions of things that are naturally functions, but that's largely for
historical reasons.)

>
> NEWS:
>    Announce change

    Annouce the above change.

...

> diff --git a/NEWS b/NEWS
> index d3c6eac..efd5232 100644
> --- a/NEWS
> +++ b/NEWS
> @@ -1,3 +1,12 @@
> +NEWS since Mercury 13.05.x
> +--------------------------
> +
> +Changes to the Mercury standard library:
> +
> +* We have added a predicate cord.condense/2 and a function
> +  cord.condense/1.


    ... *the* predicate cord.condense/2 and *the* function ...

The rest of the diff looks fine, although you should also extend the
cord test case to cover the new procedure(s).

Cheers,
Julien.



More information about the reviews mailing list