[m-rev.] Handling pull requests
paul at bone.id.au
Mon Jan 7 12:20:03 AEDT 2013
On Mon, Jan 07, 2013 at 12:09:13PM +1100, Peter Wang wrote:
> On Mon, 7 Jan 2013 11:39:12 +1100, Julien Fischer <jfischer at opturion.com> wrote:
> > On Mon, Jan 7, 2013 at 11:14 AM, Paul Bone <paul at bone.id.au> wrote:
> > > I think the bit that needs discussion is how we do code reviews now that
> > > we're using git and github. What I'd like to acheive here is a way that any
> > > of us can do code reviews, with any tools we like (eg vim and diff/patch or
> > > github or git & vim). And that the process should be simple regardless of
> > > which tools we want to use. Eg: I do not want to "force" github usage onto
> > > anyone.
> > The existing process, i.e. send the log message + patch to the mailing list,
> > is fine IMO.
> Agreed. That pull request emails don't contain the diff is a huge step
> backwards. Email + vim is better than any web interface.
> Non-core developers may prefer to send pull requests, but their changes
> won't likely be very big anyway so not much to review.
And generally non-core contributions are the exception rather than the rule.
So don't mind downloading a diff from github and then opening it with vim.
Or making any edits that I thought where good myself like I've done with
Micheal Richter's changes today.
More information about the reviews