[m-rev.] for review: fix namespace cleanliness check on Mac OS X

Paul Bone paul at bone.id.au
Mon Jan 7 14:08:36 AEDT 2013


On Fri, Jan 04, 2013 at 05:42:14PM +1100, Julien Fischer wrote:
> For review by anyone.
> 
> ----------------
> 
> Make the namespace cleanliness check work on Mac OS X.
> 
> Fix an old problem: the check_objs target would fail on Mac OS X because
> exported symbols on that platform are prefixed with "_".
> 
> Mmmake.common.in:
>     Allow object symbols to have an optional system-specific prefix.
> 
>     Delete a workaround for a problem that was fixed five years ago.
> 
> configure.ac:
>     On Darwin systems set the appropriate symbol prefix.
> 
> Julien.
> 

This looks fine to me.


-- 
Paul Bone
http://www.bone.id.au



More information about the reviews mailing list