[m-rev.] [for review 1/4] Add mfilterjavac utility

[Julien Fischer]

Hi,

On Sat, Apr 20, 2013 at 9:06 PM, Paul Bone <paul at bone.id.au> wrote:

> On Fri, Apr 19, 2013 at 06:26:23PM +1000, Julien Fischer wrote:
> >
> > Hi Paul,
> >
> > On Thu, 18 Apr 2013, Paul Bone wrote:
> >
> >> --- /dev/null
> >> +++ b/mfilterjavac/MFILTERJAVAC_FLAGS.in
> >> @@ -0,0 +1,25 @@
> >> + at BOOTSTRAP_MC_ARGS@
> >> +--no-infer-all
> >> +--halt-at-warn
> >> +--no-warn-inferred-erroneous
> >> +--no-mercury-stdlib-dir
> >> +-I../library
> >> +-I../browser
> >> +-I../ssdb
> >> +--c-include-directory ../boehm_gc
> >> +--c-include-directory ../boehm_gc/include
> >> +--c-include-directory ../runtime
> >> +--c-include-directory ../library
> >> +--c-include-directory ../library/Mercury/mihs
> >> +--c-include-directory ../browser
> >> +--c-include-directory ../browser/Mercury/mihs
> >> +--c-include-directory ../ssdb
> >> +--c-include-directory ../ssdb/Mercury/mihs
> >> +--c-include-directory ../trace
> >> +--csharp-flag -keyfile:../mercury.snk
> >> +--no-java-classpath
> >> +--java-classpath ../library/mer_rt.jar
> >> +--java-classpath ../library/mer_std.jar
> >> +--java-classpath ../browser/mer_browser.jar
> >> +--java-classpath ../mdbcomp/mer_mdbcomp.jar
> >> +--config-file ../scripts/Mercury.config.bootstrap
> >
> > There should also be:
> >
> >     --erlang-include-directory ../library/Mercury/hrls
> >
>
> This isn't in some of the other directories, is it an error for it to be
> missing from slice/SLICE_FLAGS?
>
> Do I need more --erlang-include-directory options for each of the other
> directories such as browser and mdbcomp?
>

Since you have not yet fixed bug #181, we have presumably never been
able to compile things that far in Erlang.  I think the stuff for the
Erlang backend only got added to directories where we could actually
build things.

Unfortunatly knowing how to setup a new directory or make other sagnificant
> changes to the build system doesn't appear to be documented.


Beyond, add a Mmakefile and make sure it implements the usual targets,
e.g. install, depend, clean, realclean etc, what do you have in mind?
(Bear in mind, most of the existing directories are already treated
differently
from each other.)

...


> There are two types of errors that I'm reporting.
>
>     1. An IO error where mfilterjavac cannot read javac's output.  In which
>        case javac's output would be lost and the programmer would be
> unaware
>        of it if we didn't report the error.
>
>     2. A problem parsing the markers in the .java file.  I've found this
>        useful for debugging.  I'm happy to make this a warning rather than
>        an error so that it doesn't fail an otherwise good compilation
>

I prefer the latter.

On thing I forgot to mention in my initial comments: you should update
the bootcheck script to handle mfilterjavac.  (It should be built in
stage 2 as we do with the profilers.)

Cheers,
Julien.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.mercurylang.org/archives/reviews/attachments/20130421/fb25ec1e/attachment.html>