[m-rev.] [for review] Fix some styling of the menu.
Paul Bone
paul at bone.id.au
Fri Apr 19 11:24:22 AEST 2013
On Fri, Apr 19, 2013 at 10:45:58AM +1000, Peter Wang wrote:
> On Thu, 18 Apr 2013 23:23:44 +1000, Paul Bone <paul at bone.id.au> wrote:
> > For review by Peter.
> >
> > Fix some styling of the menu.
> >
> > I've had some feedback that the sub menu options don't look/feel like menu
> > options, the user said that he didn't realize they were clickable.
>
> I don't understand that, but okay.
>
> > To try
> > to fix this I've painted them the same colour as the menu options (this
> > provide better contrast for my testes too)
>
> o_0
>
> > and made the font size the same.
> > I've also added 5px of padding on all sides of each submenu's text and
> > enabled the same hover behaviour as the main menu options. The latter two
> > changes I think help the most to show that they're clickable.
> >
> > My personal testes are that grey on white is horrible. It provides very
> > little contrast and I wish that companies such as Google and Apple wouldn't
> > do it. And I'd rather we didn't either.
> >
>
> It looks okay, but I don't like how the hover background extends past
> the hr. How about removing the hr and enlarging the padding between
> menu items to compensate?
>
That looks good too, I think I like it better as it's more minimal. Are you
happy for me to commit our combined changes?
I admit to not being very artistic so as long as it's useable and easy to
read I'm happy to listen to other people's art direction. I think the site
in general does look much better.
Thanks.
--
Paul Bone
http://www.bone.id.au
More information about the reviews
mailing list