[m-rev.] for review: format C# file names according to which C# compiler we are using

Julien Fischer juliensf at csse.unimelb.edu.au
Mon Jan 16 01:57:29 AEDT 2012



On Wed, 11 Jan 2012, Peter Ross wrote:

> On 11 January 2012 02:57, Julien Fischer <juliensf at csse.unimelb.edu.au> wrote:
>>
>> Hi Pete,
>>
>>
>> On Tue, 10 Jan 2012, Peter Ross wrote:
>>
>>> Estimated hours taken: 4
>>> Branches: main, 11.07
>>>
>>> The Microsoft C# compiler only accepts paths in the Windows format, so
>>> add code to format file names depending on which host environment we are
>>> compiling and which C# compiler we are using.
>>>
>>> compiler/compile_target_code.m:
>>>        Convert to file names to use windows paths when required.
>>>
>>> compiler/globals.m:
>>> compiler/handle_options.m:
>>> compiler/mercury_compile.m:
>>> compiler/options.m:
>>> m4/mercury.m4:
>>> scripts/Mercury.config.in:
>>>        Add code to determine the C# compiler type and pass it to the
>>> compiler.
>>>
>>> doc/user_guide.texi:
>>>        Document the --output-csharp-compiler-type option.
>>>

...

>>> +csharp_file_name(env_type_posix, csharp_mono, Filename) = Filename.
>>> +csharp_file_name(env_type_posix, csharp_unknown, Filename) = Filename.
>>> +
>>> +csharp_file_name(env_type_cygwin, csharp_microsoft, Filename) =
>>> convert_to_windows_path_format(Filename).
>>> +csharp_file_name(env_type_cygwin, csharp_mono, Filename) = Filename.
>>> +csharp_file_name(env_type_cygwin, csharp_unknown, Filename) = Filename.
>>> +
>>> +    % MSYS converts the path for us to the windows format.
>>> +csharp_file_name(env_type_msys, csharp_microsoft, Filename) = Filename.
>>> +csharp_file_name(env_type_msys, csharp_mono, Filename) = Filename.
>>> +csharp_file_name(env_type_msys, csharp_unknown, Filename) = Filename.
>>> +
>>> +csharp_file_name(env_type_win_cmd, csharp_microsoft, Filename) =
>>> convert_to_windows_path_format(Filename).
>>> +csharp_file_name(env_type_win_cmd, csharp_mono, Filename) = Filename.
>>> +csharp_file_name(env_type_win_cmd, csharp_unknown, Filename) =
>>> convert_to_windows_path_format(Filename).
>>
>>
>> The rest looks okay.  Please wait until the end of the week before
>> committing the remainder of this.

You can go ahead and commit the remainder of this now.

Julien.


More information about the reviews mailing list