[m-rev.] for post-commit review: document status of clang support

Zoltan Somogyi zs at csse.unimelb.edu.au
Mon Oct 3 16:51:10 AEDT 2011


On 03-Oct-2011, Julien Fischer <juliensf at csse.unimelb.edu.au> wrote:
> -        CFLAGS_FOR_OPT="-fomit-frame-pointer"
> + +        # Disable C compiler optimizations for old versions of clang.
> +        # (See above for details.) +        case "$C_COMPILER_TYPE" in
> +            clang_0_*|clang_1_*|clang_2_*)
> +                CFLAGS_FOR_OPT="-O0 -fomit-frame-pointer"
> +            ;;
> +            *)
> +                CFLAGS_FOR_OPT="-O2 -fomit-frame-pointer"
> +                OPT_FLAGS_FOR_CLANG="-O2"
> +            ;;
> +        esac
>          CFLAGS_FOR_DEBUG="-g"
>          CFLAGS_FOR_NO_STRICT_ALIASING="-fno-strict-aliasing"

There may or may not be a problem with line breaks above.

Shouldn't there be

	OPT_FLAGS_FOR_CLANG="-O0"

in the first branch above? I don't think the default optimization level
for gcc is 0.

Zoltan.
--------------------------------------------------------------------------
mercury-reviews mailing list
Post messages to:       mercury-reviews at csse.unimelb.edu.au
Administrative Queries: owner-mercury-reviews at csse.unimelb.edu.au
Subscriptions:          mercury-reviews-request at csse.unimelb.edu.au
--------------------------------------------------------------------------



More information about the reviews mailing list