[m-rev.] diff: fix compilation of the rbmm runtime
Julien Fischer
juliensf at csse.unimelb.edu.au
Sat Nov 12 23:28:33 AEDT 2011
(Someone familiar with the RBMM code should take a look at the XXX below.)
Branches: main
Fix compilation of the runtime in rbmm grades.
runtime/mercury_region.h:
Fix an incorrect type name.
runtime/mercury_region.c:
Add an XXX regarding a piece of code where we use the value of
an uninitialized local variable.
Julien.
Index: runtime/mercury_region.c
===================================================================
RCS file: /home/mercury/mercury1/repository/mercury/runtime/mercury_region.c,v
retrieving revision 1.12
diff -u -r1.12 mercury_region.c
--- runtime/mercury_region.c 10 Jul 2009 05:21:57 -0000 1.12
+++ runtime/mercury_region.c 12 Nov 2011 11:58:19 -0000
@@ -257,6 +257,7 @@
/*
** Loop through the protected regions and nullify the entry of the input
** region if found.
+ ** XXX FIXME num_protected_regions is not initialized at this point.
*/
for (i = 0; i < num_protected_regions; i++) {
if (ite_prot != NULL && ite_prot->MR_ite_prot_region == region) {
Index: runtime/mercury_region.h
===================================================================
RCS file: /home/mercury/mercury1/repository/mercury/runtime/mercury_region.h,v
retrieving revision 1.17
diff -u -r1.17 mercury_region.h
--- runtime/mercury_region.h 3 Nov 2011 10:13:44 -0000 1.17
+++ runtime/mercury_region.h 12 Nov 2011 11:56:03 -0000
@@ -158,7 +158,7 @@
MR_RegionCommitFixedFrame *MR_rcff_previous_commit_frame;
MR_Word MR_rcff_saved_sequence_number;
MR_RegionDisjFixedFrame *MR_rcff_saved_disj_sp;
- MR_RegionITEFixedFrame *MR_rcff_saved_ite_sp;
+ MR_RegionIteFixedFrame *MR_rcff_saved_ite_sp;
MR_Word MR_rcff_num_saved_regions;
};
--------------------------------------------------------------------------
mercury-reviews mailing list
Post messages to: mercury-reviews at csse.unimelb.edu.au
Administrative Queries: owner-mercury-reviews at csse.unimelb.edu.au
Subscriptions: mercury-reviews-request at csse.unimelb.edu.au
--------------------------------------------------------------------------
More information about the reviews
mailing list