[m-rev.] For review: Distribute the autoconf macros for pkg-config with Mercury.
Paul Bone
pbone at csse.unimelb.edu.au
Wed Nov 2 18:04:20 AEDT 2011
On Wed, Nov 02, 2011 at 05:39:49PM +1100, Julien Fischer wrote:
>
> On Wed, 2 Nov 2011, Paul Bone wrote:
>
> >
> >For review by Julien.
> >
> >
> >Distribute the autoconf macros for pkg-config with Mercury.
> >
> >This allows mercury to be compiled from CVS on hosts that don't have these
> >macros in their autoconf installation.
> >
> >acinclude.m4:
> >m4/mercury.m4:
> > Moved acinclude.m4 to m4/mercury.m4. This file contains mercury-specific
> > macros.
> >
> >m4/pkg.m4:
> > Copied pkg.m4 from the autoconf installation on taura. This file contains
> > pkg-config macros.
> >
> >Mmakefile:
> > Conform to the above changes.
> >
> >configure.in:
> > Allow the use of libhwloc to be disabled with the --without-hwloc option.
>
> That looks fine (although with changes of this sort, that's not saying
> much.)
>
> Do you also need to update tools/bootcheck as per wangp's change on
> Fri, 14 Oct 2011?
Well spotted. Thanks.
>
> Also, have you addressed my other comments regarding hwloc and mmc
> --make?
Yes, I also forgot to check this.
I'll post another diff later.
Thanks.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 490 bytes
Desc: Digital signature
URL: <http://lists.mercurylang.org/archives/reviews/attachments/20111102/870b0259/attachment.sig>
More information about the reviews
mailing list