[m-rev.] For review: Thread pinning improvements.

Paul Bone pbone at csse.unimelb.edu.au
Wed Nov 2 15:47:14 AEDT 2011


On Sat, Oct 22, 2011 at 01:16:58AM +1100, Julien Fischer wrote:
> 
> On Wed, 5 Oct 2011, Paul Bone wrote:
> 
> >
> >configure.in:
> >Mmake.common.in:
> >   Detect presence of the hwloc library.
> 
> ...
> 
> >Index: configure.in
> >===================================================================
> >RCS file: /home/mercury1/repository/mercury/configure.in,v
> >retrieving revision 1.596
> >diff -u -p -b -r1.596 configure.in
> >--- configure.in	4 Oct 2011 02:37:57 -0000	1.596
> >+++ configure.in	4 Oct 2011 14:31:39 -0000
> >@@ -1265,7 +1265,7 @@ mercury_check_for_functions \
> >        grantpt unlockpt ptsname tcgetattr tcsetattr ioctl \
> >        access sleep opendir readdir closedir mkdir symlink readlink \
> >        gettimeofday setenv putenv _putenv posix_spawn sched_setaffinity \
> >-        sched_getcpu sched_yield mkstemp
> >+        sched_getaffinity sched_getcpu sched_yield mkstemp
> >
> >#-----------------------------------------------------------------------------#
> >
> >@@ -5107,6 +5107,30 @@ MERCURY_CHECK_READLINE
> >
> >#-----------------------------------------------------------------------------#
> >#
> >+# Check for libhwloc, http://www.open-mpi.org/projects/hwloc/
> >+#
> >+PKG_PROG_PKG_CONFIG
> 
> The above macro will abort if pkg-config is not available on the system.
> This dependency is not documented anywhere but in any case it needs to be
> removed since we build on systems where it isn't available.

Actually it doesn't abort if pkg-config is not available, but aclocal &
andoconf will build a bad ./configure script if the macro (not pkg-config its
self) are not available when they are run.  This means that you cannot build
from CVS on a system without this macro, but you can build from the source
distribution which provides a ./configure script.

I guess that you _do_ want to build from CVS on such systems, therefore I'll
distribute these files with Mercury.

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 490 bytes
Desc: Digital signature
URL: <http://lists.mercurylang.org/archives/reviews/attachments/20111102/aa362e17/attachment.sig>


More information about the reviews mailing list