[m-rev.] For review by Zoltan: Fix some auto-parallelism problems.

Zoltan Somogyi zs at csse.unimelb.edu.au
Sun Jan 23 16:09:52 AEDT 2011


On 23-Jan-2011, Paul Bone <pbone at csse.unimelb.edu.au> wrote:
> deep_profiler/program_represetnation_utils.m:
>     As above.

Filename spelling.

> compiler/mercury_compile_front_end.m:
>     Add the new constructor symbol for the new simplification pass.
> 
>     Perform a 'do once' simplification pass for the new simplification pass.

That last sentence does not make sense.

> @@ -864,6 +869,21 @@ maybe_simplify(Warn, SimplifyPass, Verbo
>                  !:SimpList = []
>              )
>          ;
> +            SimplifyPass =simplify_pass_pre_implicit_parallelism,

Add space after =.

> +    maybe_simplify(no, simplify_pass_pre_implicit_parallelism, Verbose, Stats,
> +        !HLDS, [], SimplifySpecsPreImpPar, !IO),
> +    expect(unify(contains_errors(Globals, SimplifySpecsPreImpPar), no),
> +        this_file, "middle_pass: simplify has errors"),

Delete this expect. While simplify should not find any errors, it may find
warnings, and those will be in SimplifySpecsPreImpPar as well.

> @@ -237,8 +244,8 @@ middle_pass(ModuleName, !HLDS, !DumpInfo
>      % propagation and we cannot do that once the term-size profiling or deep
>      % profiling transformations have been applied.
>      maybe_simplify(no, simplify_pass_pre_prof_transforms, Verbose, Stats,
> -        !HLDS, [], SimplifySpecs, !IO),
> -    expect(unify(contains_errors(Globals, SimplifySpecs), no), this_file,
> +        !HLDS, [], SimplifySpecsPreProf, !IO),
> +    expect(unify(contains_errors(Globals, SimplifySpecsPreProf), no), this_file,

Same here.

The rest is fine.

Zoltan.
--------------------------------------------------------------------------
mercury-reviews mailing list
Post messages to:       mercury-reviews at csse.unimelb.edu.au
Administrative Queries: owner-mercury-reviews at csse.unimelb.edu.au
Subscriptions:          mercury-reviews-request at csse.unimelb.edu.au
--------------------------------------------------------------------------



More information about the reviews mailing list