[m-rev.] For review: Improvments to Stack Segments code.

Julien Fischer juliensf at csse.unimelb.edu.au
Thu Feb 24 19:24:47 AEDT 2011

On Tue, 22 Feb 2011, Paul Bone wrote:

> I previously posted part of this patch for review but it was rejected because
> support for feeing the stack segments had not been implemented yet.  That work
> has been completed and I beleive the patch is ready.
> It bootchecs in asm_fast.gc and asm_fast.gc.stseg, it was also tested in the
> .par grades but that was a little while ago.  Work that builds on it will
> require those tests too.
> Could somebody please help by testing this patch with the trailing grades with
> G12.

Ok, I've tested G12 with the grade asm_fast.gc.stseg.trseg**,
asm_fast.gc.trseg and hlc.gc.trseg and everything seems fine.

Timings for the large variant of the G12/FD test suite are as follows:

Grade				Old			New
-----				---			---
hlc.gc.trseg			105s			106s
asm_fast.gc.trseg		128s			128s
asm_fast.gc.stseg.trseg		133s			135s

In short, there's no significant performance difference with this
change.  (In passing, I would note that the gap between the performance
of asm_fast.gc.trseg and hlc.gc.trseg versions of the G12/FD solver
seems have widened.)

I'll run further tests in a couple of other trailing grades, but I
expect they won't show anything up either.

** incidentally, some parts of the Mercury compiler are a bit confused
as to what the canonical name for this grade is, e.g. mmc
--output-libgrades reports both asm_fast.gc.trseg.stseg and
asm_fast.gc.stseg.trseg as being present.

mercury-reviews mailing list
Post messages to:       mercury-reviews at csse.unimelb.edu.au
Administrative Queries: owner-mercury-reviews at csse.unimelb.edu.au
Subscriptions:          mercury-reviews-request at csse.unimelb.edu.au

More information about the reviews mailing list