[m-rev.] for review: further MinGW README changes

Julien Fischer juliensf at csse.unimelb.edu.au
Fri Feb 18 15:27:45 AEDT 2011




On Thu, 17 Feb 2011, Ian MacLarty wrote:

> On Wed, Feb 16, 2011 at 3:28 PM, Julien Fischer
> <juliensf at csse.unimelb.edu.au> wrote:
>>
>> For review by anyone.
>>
>> Branches: main, 11.01
>>
>> Further work on the MinGW README file.
>>
>> README.MinGW:
>>        Reword the introduction.
>>
>>        Mention that if the pthreads-win32 library is installed the the
>>        high-level C parallel grades can be installed.
>>
>>        Mention that the low-level C parallel grades do not currently
>>        work on Windows.
>>
>>        Add a section on reconfiguring the Mercury compiler so that it
>>        can work directly from the Windows command prompt.
>>
>> Julien.
>>
>> Index: README.MinGW
>> ===================================================================
> ...
>> +(1) Check that no Unix style paths are used in the values of the following
>> +    variables:
>> + +     MERCURY_C_COMPILER
>> +       MERCURY_JAVA_COMPILER
>> +       MERCURY_JAVA_INTERPRETER
>> +       MERCURY_CSHARP_COMPILER
>> +       MERCURY_ERLANG_COMPILER
>> +       MERCURY_ERLANG_INTERPRETER
>> +
>
> It might be worth elaborating on what the paths should look like.  For
> example is c:/my/path (with forward slashes) allowed.

Forwards slashes are allowed under the UNC, but generally not used on
Windows since many programs use forward slash for command line options.

I have added:

   If Unix style paths occur, replace them with a Windows style path
   that conforms to the Windows Uniform Naming Convention (UNC), for
   example:

         MERCURY_ERLANG_COMPILER=/c/Program\ Files/erl5.8.2/bin/erlc

    should be replaced with:

         MERCURY_ERLANG_COMPILER=C:\Program Files\erl5.8.2\bin\erlc

> Do I need to escape spaces in the paths?

I don't think so.  I will check before I commit though.

Julien.


More information about the reviews mailing list