[m-rev.] for review: unicode command line arguments on windows

Peter Wang novalazy at gmail.com
Thu Dec 15 17:51:51 AEDT 2011


On Thu, 15 Dec 2011 17:32:06 +1100 (EST), Julien Fischer <juliensf at csse.unimelb.edu.au> wrote:
> 
> Ok, let me try and get this straight:
> 
> (1) __wgetmainargs works with MinGW
> (2) wmain works with MSVC

Yes.

> So let's do that - I would actually make the code conditional on MR_MSVC
> rather than MR_MINGW though.  I suggest breaking mercury_win32_args in
> two since the lower part of it should be usable by both of them.

I would make __wgetmainargs conditional on MR_MINGW and wmain
conditional on MR_MSVC until we know either works with other compilers.

> 
> > It's probably better for you to modify the patch and commit it directly.
> 
> That's fine with me.

Thanks, I'll leave it to you.

Peter
--------------------------------------------------------------------------
mercury-reviews mailing list
Post messages to:       mercury-reviews at csse.unimelb.edu.au
Administrative Queries: owner-mercury-reviews at csse.unimelb.edu.au
Subscriptions:          mercury-reviews-request at csse.unimelb.edu.au
--------------------------------------------------------------------------



More information about the reviews mailing list