[m-rev.] for review: unicode command line arguments on windows

Peter Wang novalazy at gmail.com
Thu Dec 15 17:16:25 AEDT 2011


On Thu, 15 Dec 2011 16:46:22 +1100 (EST), Julien Fischer <juliensf at csse.unimelb.edu.au> wrote:
> 
> Unfortunately it didn't help much :-(
> 
> mslice_init.obj : error LNK2019: unresolved external symbol
> __imp__CommandLineToArgvW at 8 reference in function _mercury_win32_args

That looks like it came from the previous version of mkinit.

> > For MSVC we have the option of using
> >    wmain(int argc, wchar_t *argv[], wchar_t *envp[])
> 
> Perhaps the best thing to do is just
> 
>    #if defined(MR_MSVC)
>       wmain(...)
>    #else
>       main(...) + call mercury_win32_args on argv in this case
>    #endif
> 
> (It looks as though mingw-gcc doesn't support wmain.)

Yes, otherwise I would have used wmain to begin with.

How do you want to proceed?  I could modify my patch to be conditional
on MR_MINGW and commit it, then let you handle the changes for MSVC.
It's probably better for you to modify the patch and commit it directly.

And what about cygwin?

Peter
--------------------------------------------------------------------------
mercury-reviews mailing list
Post messages to:       mercury-reviews at csse.unimelb.edu.au
Administrative Queries: owner-mercury-reviews at csse.unimelb.edu.au
Subscriptions:          mercury-reviews-request at csse.unimelb.edu.au
--------------------------------------------------------------------------



More information about the reviews mailing list