[m-rev.] for review: unicode paths on windows

[Julien Fischer]

On Wed, 14 Dec 2011, Peter Wang wrote:

> On Wed, 14 Dec 2011 14:41:52 +1100 (EST), Julien Fischer <juliensf at csse.unimelb.edu.au> wrote:
>>
>> I suggest that you explicitly deallocate the result of the call to
>> ML_utf8_to_wide after the call to FindFirstFile using MR_GC_free.
>> (Any anywhere else that function is called.)
>> Doing so will be a bit nicer for the nogc grades.
>
> You mean every instance of ML_utf8_to_wide?  That's rather ugly to
> almost no end.

I agree, the need for it is almost vanishingly small.  OTOH, I have
just spent a fair chunk of time debugging memory related issues on
Windows, so I would prefer it if the nogc version of the stdlib didn't
look as though it was leaking memory where possible ...

> If you insist, I can do it in a later change.

It's not urgent and can wait.

> Meanwhile I found more functions.  Committed with these additional
> changes.

They look fine.

Julien.
--------------------------------------------------------------------------
mercury-reviews mailing list
Post messages to:       mercury-reviews at csse.unimelb.edu.au
Administrative Queries: owner-mercury-reviews at csse.unimelb.edu.au
Subscriptions:          mercury-reviews-request at csse.unimelb.edu.au
--------------------------------------------------------------------------