[m-rev.] for review: fix float field structure padding/packing problems

[Peter Wang]

On Mon, 5 Dec 2011 18:57:47 +1100 (EST), Julien Fischer <juliensf at csse.unimelb.edu.au> wrote:
> 
> Hi Peter,
> 
> On Mon, 5 Dec 2011, Peter Wang wrote:
> 
> > Can someone apply this and test with MSVC and MinGW?
> 
> Shall do.  Has it been tested with clang?

Not yet.

> > I've only tested the single precision floats on 64-bit Linux part.
> >
> > Would it be worth avoiding the C extensions when
> > sizeof(MR_Float) == sizeof(MR_Word)?  That can't be evaluated by the C
> > preprocessor, though.
> 
> The configure script could make that test and define
> MR_FLOAT_IS_WORD_SIZED or something if that condition is true.

No, it depends on the grade being targeted.

> I'll review the rest later - although could you please go ahead and commit the
> test case for bug #240 now.

Done.

Peter
--------------------------------------------------------------------------
mercury-reviews mailing list
Post messages to:       mercury-reviews at csse.unimelb.edu.au
Administrative Queries: owner-mercury-reviews at csse.unimelb.edu.au
Subscriptions:          mercury-reviews-request at csse.unimelb.edu.au
--------------------------------------------------------------------------