[m-rev.] for review: unboxed floats in high-level C grades

[Paul Bone]

On Fri, Aug 19, 2011 at 01:25:21PM +1000, Julien Fischer wrote:
> 
> On Fri, 19 Aug 2011, Peter Wang wrote:
> 
> >All the other elements are mlds_generic_type.  I'll make that clearer.
> >
> >>>+            % This is the same as mlds_array_type(mlds_generic_type) except
> >>>+            % that some element types are mlds_native_float_type instead of
> >>>+            % mlds_generic_type.
> >>
> >>That begs the question, why is it not called something like
> >>mlds_float_array_type?  (Do you envisage it being used for element types
> >>other than floats in the future?)
> >
> >Yes, it could be used for 64-bit integers on 32-bit platforms.
> 
> Ok.
> 
> >>>In C, it is not possible to initialize an
> >>>+            % element of a generic array with a float literal, so we replace
> >>>+            % them with a structure type with some float fields.
> >>
> >>That looks good otherwise.
> >>
> >>(Incidentally, I've added a version of the n-body benchmark from the
> >>programming language shootout or whatever it calls itself these days
> >>to the benchmarks; you may want to try this change out on it -- it should
> >>make a substantial difference**.)
> >
> >Excellent.  But I'm locked out:
> >
> >-r--r--r--+ 1 juliensf g12 7457 2011-08-18 17:09 nbody.m,v
> 
> Hmmmm, how on earth did that happen?  It's fixed now.
> 

Check the permissions on the directory.  The directory should be chgrp mercury
and chmod g+s

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 490 bytes
Desc: Digital signature
URL: <http://lists.mercurylang.org/archives/reviews/attachments/20110819/451084ee/attachment.sig>