[m-rev.] for post-commit review: switches on strings without gotos

Peter Wang novalazy at gmail.com
Mon Aug 15 18:12:43 AEST 2011


On 2011-08-15, Zoltan Somogyi <zs at csse.unimelb.edu.au> wrote:
> +            globals.lookup_string_option(Globals, experiment, Experiment),
> +            (
> +                SupportsBreakContinue = yes,
> +                OnlyFailAfterStatements = [],
> +                Experiment \= "use_end_label"
> +            ->
...
> +            ;
> +                ml_gen_new_label(EndLabel, !Info),
> +                GotoCommentStatement = statement(ml_stmt_atomic(
> +                    comment("jump out of search loop")), MLDS_Context),
> +                GotoEndStatement =
> +                    statement(ml_stmt_goto(goto_label(EndLabel)),
> +                        MLDS_Context),

Gotos are used if OnlyFailAfterStatements \= [].

Peter
--------------------------------------------------------------------------
mercury-reviews mailing list
Post messages to:       mercury-reviews at csse.unimelb.edu.au
Administrative Queries: owner-mercury-reviews at csse.unimelb.edu.au
Subscriptions:          mercury-reviews-request at csse.unimelb.edu.au
--------------------------------------------------------------------------



More information about the reviews mailing list