[m-rev.] for review: use semidet predicate for whitespace skipper

Paul Bone pbone at csse.unimelb.edu.au
Wed Apr 20 10:41:31 AEST 2011

On Tue, Apr 19, 2011 at 06:34:34PM +1000, Ian MacLarty wrote:
> For review by anyone.
> Estimated hours taken: 2
> Branches: main
> Turn the whitespace skipping function into a semidet
> predicate with the same signature as all the other parsing
> predicates.
> Sometimes you want whitespace skipping to fail, for example
> if there is no matching */ in a C style comment.
> library/parsing_utils.m:
>     Make the whitespace skipping function a predicate.
> tests/general/test_parsing_utils.m:
> tests/general/test_parsing_utils.exp:
>     Test failure of whitespace skipping predicate.

This is fine with me.  The diff looks good.

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 490 bytes
Desc: Digital signature
URL: <http://lists.mercurylang.org/archives/reviews/attachments/20110420/3839688d/attachment.sig>

More information about the reviews mailing list