[m-rev.] for review: use semidet predicate for whitespace skipper
pbone at csse.unimelb.edu.au
Wed Apr 20 10:41:31 AEST 2011
On Tue, Apr 19, 2011 at 06:34:34PM +1000, Ian MacLarty wrote:
> For review by anyone.
> Estimated hours taken: 2
> Branches: main
> Turn the whitespace skipping function into a semidet
> predicate with the same signature as all the other parsing
> Sometimes you want whitespace skipping to fail, for example
> if there is no matching */ in a C style comment.
> Make the whitespace skipping function a predicate.
> Test failure of whitespace skipping predicate.
This is fine with me. The diff looks good.
-------------- next part --------------
A non-text attachment was scrubbed...
Size: 490 bytes
Desc: Digital signature
More information about the reviews