[m-rev.] for review: signed character conversion bugs

Julien Fischer juliensf at csse.unimelb.edu.au
Wed Sep 15 14:08:36 AEST 2010


On Wed, 15 Sep 2010, Peter Wang wrote:

> Branches: main, 10.04
>
> Fix problems with characters being converted to integers without an
> (MR_UnsignedChar) cast.
>
> compiler/polymorphism.m:
>         Characters must use `private_builtin.builtin_compare_character'
>         instead of that for int, otherwise we may miss an (MR_UnsignedChar)
>         cast.
>
> runtime/mercury_builtin_types.c:
>         Add missing (MR_UnsignedChar) casts to
>         `mercury__builtin____Compare____character_0_0'.

That looks fine.

Julien.
--------------------------------------------------------------------------
mercury-reviews mailing list
Post messages to:       mercury-reviews at csse.unimelb.edu.au
Administrative Queries: owner-mercury-reviews at csse.unimelb.edu.au
Subscriptions:          mercury-reviews-request at csse.unimelb.edu.au
--------------------------------------------------------------------------



More information about the reviews mailing list