[m-rev.] for review: csharp.ssdebug and readme

Julien Fischer juliensf at csse.unimelb.edu.au
Tue Oct 26 17:24:46 AEDT 2010

On Tue, 26 Oct 2010, Peter Wang wrote:

> On 2010-10-25, Julien Fischer <juliensf at csse.unimelb.edu.au> wrote:
>> Hi Peter,
>> On Mon, 25 Oct 2010, Peter Wang wrote:
>>> Branches: main
>>> Make it possible to install and use the csharp.ssdebug grade.
>>> Mmake.workspace:
>>>       Never try to link with `mer_rt' in C# grades.
>>> browser/Mmakefile:
>>> mdbcomp/Mmakefile:
>>> ssdb/Mmakefile:
>>>       Use `mmc --make' to install these libraries in `csharp' grades.
>>>       Don't add C libraries to MLLIBS in non-C or asm grades.
>>> browser/Mercury.options:
>>> ssdb/Mercury.options:
>>>       "EXTRA_LIBRARIES-libname" doesn't actually work with `mmc --make',
>>>       but "LIBRARIES-name" does.
>> Bug or feature?
> I would say bug.  I have looked through the CVS history and it has been
> so since the initial implementation.

The User's guide suggests that it should be supported, it says:

     The Mmake variables above can be used by mmc --make if they
     are set in a file called Mercury.options.

However, I seem to remember from discussion elsewhere (on the mailing
list?), that Mercury.options files only recognise a subset of them.

I suggest you file a bug against this one, and we can try to get
it cleaned up (documenting Mercury.options files properly would be
a start) for 11.01.

>> Either way, please check that this change doesn't break things.
>> (Acutally, why does it not affect the Java and Erlang grades?)
> Erlang: those libraries are never built in erlang grades
> Java: was done by setting --java-classpath in the FLAGS files;
>    --mercury-library is ignored (another bug)
> More mysterious is the effect on C grades, since that line apparently
> never worked.

It's possible that the correct options get pulled in from the .mgnuc*

The rest of your changes look fine.
It may be worth commenting out some of the user-level documentation for
the old .NET backend.  (In particular the presence of the configure
option --enable-dotnet-grades may be confusing.)

When you feel ready to unleash the C# backend on the rest of the world,
you should also update the NEWS file, webpage etc.

mercury-reviews mailing list
Post messages to:       mercury-reviews at csse.unimelb.edu.au
Administrative Queries: owner-mercury-reviews at csse.unimelb.edu.au
Subscriptions:          mercury-reviews-request at csse.unimelb.edu.au

More information about the reviews mailing list