[m-rev.] For review: Make improvements to stack segments code.

Julien Fischer juliensf at csse.unimelb.edu.au
Mon Jun 7 22:53:45 AEST 2010


On Mon, 7 Jun 2010, Paul Bone wrote:

>    MR_construct_zone.
>
>>>    error handlers.
>>>
>>>    Do better locking on the free_memory_zones and used_memory_zones lists.
>>
>> Better locking in what sense?
>>
>
>    Updates to used_memory_zones now use a pthread mutex so that only one
>    thread may be updating the list at once.  This lock is shared with the
>    free_memory_zones structure.

Just to be clear, the intent of my comment was that you should say as
such in the log message.

...

>> Please post a revised log message and diff once you have addressed the
>> above.
>
> Okay,  There also seem to be some problems with hlc.gc.par, so I'll address
> those before I re-post it.

You should also test in a trseg grade and probably one of the mmos
grades.

Julien.

--------------------------------------------------------------------------
mercury-reviews mailing list
Post messages to:       mercury-reviews at csse.unimelb.edu.au
Administrative Queries: owner-mercury-reviews at csse.unimelb.edu.au
Subscriptions:          mercury-reviews-request at csse.unimelb.edu.au
--------------------------------------------------------------------------



More information about the reviews mailing list