[m-rev.] For post-commit review: Create threadscope grade component
Peter Wang
novalazy at gmail.com
Tue Jan 12 10:42:05 AEDT 2010
On 2010-01-10, Paul Bone <pbone at csse.unimelb.edu.au> wrote:
>
> For post-commit review.
>
> I've tested this change as described in the mailing list in a number of
> different grades and by installing the compiler and testing mmake and mmc
> --make against it.
> Index: scripts/canonical_grade.sh-subr
> ===================================================================
> RCS file: /home/mercury1/repository/mercury/scripts/canonical_grade.sh-subr,v
> retrieving revision 1.22
> diff -u -p -b -r1.22 canonical_grade.sh-subr
> --- scripts/canonical_grade.sh-subr 5 Sep 2008 11:19:34 -0000 1.22
> +++ scripts/canonical_grade.sh-subr 9 Jan 2010 12:59:26 -0000
> @@ -81,9 +81,15 @@ case $gcc_nested_functions,$highlevel_co
> *) ;;
> esac
>
> -case $thread_safe in
> - true) GRADE="$GRADE.par" ;;
> - false) ;;
> +case $thread_safe,$threadscope in
> + true,false) GRADE="$GRADE.par" ;;
> + true,true) GRADE="$GRADE.par.threadscope" ;;
> + false,false) ;;
> + *)
> + echo "$progname: error: The 'threadscope' grade component may only be" 1>&2
> + echo "$progname: error: used in parallel grades"
> + exit 1
> + ;;
> esac
1>&2 is missing on the second line. Looks okay otherwise.
Peter
--------------------------------------------------------------------------
mercury-reviews mailing list
Post messages to: mercury-reviews at csse.unimelb.edu.au
Administrative Queries: owner-mercury-reviews at csse.unimelb.edu.au
Subscriptions: mercury-reviews-request at csse.unimelb.edu.au
--------------------------------------------------------------------------
More information about the reviews
mailing list