[m-rev.] For review: Fix the handling of $DESTDIR on Windows.

[Paul Bone]

On Fri, Dec 17, 2010 at 02:37:04AM +1100, Julien Fischer wrote:
> 
> On Thu, 16 Dec 2010, Paul Bone wrote:
> 
> >
> >Julien had some comments in person, this patch fixes them.  I've placed it for
> >review since it's too easy to make mistakes when modifying the build system.
> >
> >---
> >
> >Mmke.vars.in:
> >   Modify the documentation that discuss how to override INSTALL_PATH
> 
> s/discuss/discusses/
> 
> >   to describe setting of $DESTDIR instead.
> >
> >   Don't add a slash before INSTALL_PATH if DESTDIR is empty since this
> >   breaks installation on Windows.  (This change has already been made
> >   in Mmake.common.in)
> >
> >   Set more FINAL_INSTALL_ variables to support the new code in
> >   Mmakefile and bindist.Makefile.in.
> >
> >Mmake.common.in:
> >   Improve the prose in a comment.
> >
> >Mmakefile:
> >bindist/bindist.Makefile.in:
> >   Update installation message.
> >
> >   Tell the user that their install is in $(DESTDIR) if applicable.
> >
> >   Use FINAL_INSTALL variables rather than INSTALL variables.
> 
> I don't think the changes to bindist.Makefile.in are correct - it's
> not connected with mmake stuff.  INSTALL_PREFIX is set by the
> bindist INSTALL script for that -- in any case why would you want
> to use DESTDIR with the binary distribution?

Ah, a comment in Mmakefile told me that the install code was repreated there so
I duplicated my change.  I didn't notice that this was a regular Makefile and
not a Mmakefile.

I'll remove the changes to bindist.Makefile.in and fix the grammar above then
commit.

Thanks.

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 490 bytes
Desc: Digital signature
URL: <http://lists.mercurylang.org/archives/reviews/attachments/20101217/cd5c9390/attachment.sig>