[m-rev.] diff: Increase HBLKSIZE in BoehmGC for parallel grades.

Julien Fischer juliensf at csse.unimelb.edu.au
Thu Dec 9 17:16:45 AEDT 2010


On Thu, 9 Dec 2010, Paul Bone wrote:

> On Wed, Dec 08, 2010 at 04:17:38PM +1100, Julien Fischer wrote:
>> On Wed, 8 Dec 2010, Paul Bone wrote:
>>> Index: Mmake.common.in
>>> ===================================================================
>>> RCS file: /home/mercury1/repository/mercury/Mmake.common.in,v
>>> retrieving revision 1.97
>>> diff -u -p -b -r1.97 Mmake.common.in
>>> --- Mmake.common.in	10 Oct 2009 10:44:13 -0000	1.97
>>> +++ Mmake.common.in	8 Dec 2010 03:50:43 -0000
>>> @@ -150,7 +150,8 @@ BOEHM_CFLAGS = @ENABLE_BOEHM_LARGE_CONFI
>>> # Additional options to pass to the C compiler when building Boehm-GC for
>>> # threads.
>>> BOEHM_CFLAGS_FOR_THREADS = @ENABLE_BOEHM_THREAD_LOCAL_ALLOC@ \
>>> -	@ENABLE_BOEHM_PARALLEL_MARK@
>>> +	@ENABLE_BOEHM_PARALLEL_MARK@ \
>>> +	-DHBLKSIZE=32768 -DCPP_LOG_HBLKSIZE=15
>>
>> I suggest adding a comment above that definition describing what
>> HBLKSIZE and CPP_LOG_HBLKSIZE are.
>>
>
> Fixed.

The comment should also explain *why* we set them, i.e. because it
improves the performance of the GC in par grades.

Julien.
--------------------------------------------------------------------------
mercury-reviews mailing list
Post messages to:       mercury-reviews at csse.unimelb.edu.au
Administrative Queries: owner-mercury-reviews at csse.unimelb.edu.au
Subscriptions:          mercury-reviews-request at csse.unimelb.edu.au
--------------------------------------------------------------------------



More information about the reviews mailing list