[m-rev.] for post-commit review: fix "mmake tags"

[Paul Bone]

On Tue, Sep 22, 2009 at 02:36:32PM +1000, Zoltan Somogyi wrote:
> compiler/Mmakefile:
> 	Fix an old bug. The action for the target "tags_file_exists", which is
> 	implicitly remade whenever we rebuild the compiler, used to always
> 	touch .compiler_tags. This led the "tags" target to believe that
> 	the tags file (whose logical timestamp .compiler_tags represents)
> 	is at least as new as all the .m files, causing it to not actually
> 	remake the tags file, even when it should have.
> 
> 	We now touch .compiler_tags only when rebuilding the tags file.
> 
> */Mmakefile:
> 	Make the actions for tags follow the scheme in compiler/Mmakefile
> 	where needed.
> 
> Zoltan.
> 
> Index: browser/Mmakefile
> ===================================================================
> RCS file: /home/mercury/mercury1/repository/mercury/browser/Mmakefile,v
> retrieving revision 1.56
> diff -u -b -r1.56 Mmakefile
> --- browser/Mmakefile	14 Sep 2009 05:58:22 -0000	1.56
> +++ browser/Mmakefile	21 Sep 2009 06:18:52 -0000
> @@ -194,13 +194,20 @@
>  
>  #-----------------------------------------------------------------------------#
>  
> -tags:	$(MTAGS) $($(BROWSER_LIB_NAME).ms)
> +tags:	.browser_tags
> +
> +.browser_tags: 	$(MTAGS) $($(BROWSER_LIB_NAME).ms) \
> +		$(wildcard $(LIBRARY_DIR)/*.m) \
> +                $(wildcard $(MDBCOMP_DIR)/*.m)
>  	$(MTAGS) $($(BROWSER_LIB_NAME).ms) ../mdbcomp/*.m ../library/*.m
> +	@touch .browser_tags
>  
>  .PHONY: tags_file_exists
>  tags_file_exists:
>  	@if test ! -f tags; then echo making tags; \
> -	$(MTAGS) $($(BROWSER_LIB_NAME).ms) ../mdbcomp/*.m ../library/*.m ; fi
> +	$(MTAGS) $($(BROWSER_LIB_NAME).ms) ../mdbcomp/*.m ../library/*.m; \
> +	touch .browser_tags; \
> +	fi
> 

Is it possible to have indenting here (and places like it) or is it simply not
shown in the diff?

Otherwise this is good.

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 489 bytes
Desc: Digital signature
URL: <http://lists.mercurylang.org/archives/reviews/attachments/20090922/41c8eda1/attachment.sig>