[m-rev.] for review: allow pretest equality on java

Julien Fischer juliensf at csse.unimelb.edu.au
Fri Sep 18 20:40:29 AEST 2009


On Wed, 16 Sep 2009, Peter Wang wrote:

> Branches: main
>
> Allow `--should-pretest-equality' on Java backend.
>
> compiler/options.m:
> compiler/handle_options.m:
>        Set an internal option when targetting Java which determines whether
>        "pretest equality" code casts values to pointers or integers before
>        comparing them.
>
>        Allow `should_pretest_equality' when targetting Java.
>
> compiler/hlds_goal.m:
> compiler/saved_vars.m:
>        Add a goal feature to be set on the unification in the pretest equality
>        code.
>
> compiler/modecheck_unify.m:
>        Treat c_pointer unifications as a simple test if the previous goal
>        feature is set.  Otherwise the result would be a runtime error.
>
> compiler/unify_proc.m:
>        Make the pretest equality code cast values to pointers if
>        `pretest_equality_cast_pointers' is set.
>
>        Add the goal feature on the unification goal.

That looks ok - do you know how much of a difference it makes?

Julien.
--------------------------------------------------------------------------
mercury-reviews mailing list
Post messages to:       mercury-reviews at csse.unimelb.edu.au
Administrative Queries: owner-mercury-reviews at csse.unimelb.edu.au
Subscriptions:          mercury-reviews-request at csse.unimelb.edu.au
--------------------------------------------------------------------------



More information about the reviews mailing list