[m-rev.] for post-commit review: don't create redundant type_infos

[Zoltan Somogyi]

On 14-Sep-2009, Mark Brown <mark at csse.unimelb.edu.au> wrote:
> > +        % We did introduced some variables into the scope, so we cannot
> 
> s/introduced/introduce/

Fixed.

> > -    % Type(class)-infos for ground types added to predicate calls, function
> > -    % calls and existentially typed construction unifications do not require
> > -    % requantification because they are local to the conjunction containing
> > -    % the type(class)-info construction and the goal which uses the
> > +    % Type(class)-infos added for ground types added to predicate calls,
> 
> This makes less sense than before.  Should the second 'added' be 'passed'?

Yes; done.

> > @@ -3451,6 +3605,9 @@
> >                  % Specifies the constraints at each location in the goal.
> >                  poly_constraint_map     :: constraint_map,
> >  
> > +                poly_type_info_var_map  :: type_info_var_map,
> > +                poly_num_reuses         :: int,
> > +
> 
> You should document these fields.  In particular, that the map only contains
> some but not all type_infos that are available (i.e., it's for optimisation).

Done.

Zoltan.
--------------------------------------------------------------------------
mercury-reviews mailing list
Post messages to:       mercury-reviews at csse.unimelb.edu.au
Administrative Queries: owner-mercury-reviews at csse.unimelb.edu.au
Subscriptions:          mercury-reviews-request at csse.unimelb.edu.au
--------------------------------------------------------------------------