[m-rev.] for post-commit review: don't create redundant type_infos

[Mark Brown]

Hi,

On 14-Sep-2009, Mark Brown <mark at csse.unimelb.edu.au> wrote:
> On 14-Sep-2009, Zoltan Somogyi <zs at csse.unimelb.edu.au> wrote:
> > For review by Mark. Could someone from G12 (a) measure the effect this has
> > on the code that was the motivation for this change, and (b) tell me if
> > the same thing needs to be done for the creation of redundant typeclass_infos.
> 
> The change is fine, apart from a couple of comments below.  I'll do (a)
> shortly and let you know; I expect the answer to (b) will be yes, but I'll
> take a look at the hlds dumps from (a) and see.
> 

The number of variables in the procedure that was causing problems has
roughly halved.  Compilation time has significantly improved but is still
likely to be a problem for some models.  E.g., compiling it in asm_fast
there is still most of a minute spent computing liveness for that procedure,
where it was more like 10 minutes previously.

The remaining variables are largely redundant typeclass_infos.  Note that
most type_ctor_infos are indirectly reused via the type_info they are built
for, so there are almost no redundant type_ctor_infos in this case.

Cheers,
Mark.

--------------------------------------------------------------------------
mercury-reviews mailing list
Post messages to:       mercury-reviews at csse.unimelb.edu.au
Administrative Queries: owner-mercury-reviews at csse.unimelb.edu.au
Subscriptions:          mercury-reviews-request at csse.unimelb.edu.au
--------------------------------------------------------------------------