[m-rev.] for review: --warn-suspicious-foreign-procs

[Julien Fischer]

On Tue, 8 Sep 2009, Zoltan Somogyi wrote:

> On 07-Sep-2009, Peter Wang <novalazy at gmail.com> wrote:
>>> (3) the presence of "return" (or "ret" or "jmp" in IL).  This could
>>> indicate the presence of a return statement in the foreign proc.
>>
>> In the case of (3) this could occur quite often which might limit
>> uptake of the option.  Which would be a shame as the success indicator
>> checks should be safe and useful to enable by default.
>
> You could reduce false matches by (a) filtering out comments in the syntax of
> the relevant foreign language, and (b) searching not for any match, but only
> with the equivalent of "egrep -w".

I'll look at doing this in a later change.

Julien.
--------------------------------------------------------------------------
mercury-reviews mailing list
Post messages to:       mercury-reviews at csse.unimelb.edu.au
Administrative Queries: owner-mercury-reviews at csse.unimelb.edu.au
Subscriptions:          mercury-reviews-request at csse.unimelb.edu.au
--------------------------------------------------------------------------